Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode-eslint settings #505

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix vscode-eslint settings #505

merged 3 commits into from
Mar 15, 2024

Conversation

SamB
Copy link
Contributor

@SamB SamB commented Mar 15, 2024

I ran into a few papercuts with peggy.code-workspace:

  1. vscode-eslint wasn't using the settings from eslint.config.js, so I fixed that
  2. the workspace had vscode-eslint set as the default formatter for all languages, so I fixed that
  3. peggy.code-workspace was indented with tabs, but .editorconfig said to use spaces for all files, so I reindented the file

Then, of course, I painstakingly committed each of those changes in the opposite order.

 It can really only format JavaScript and TypeScript.
Apparently it doesn't try to load these by default yet.
@hildjj hildjj merged commit 6e1f0fb into peggyjs:main Mar 15, 2024
9 checks passed
@hildjj
Copy link
Contributor

hildjj commented Mar 15, 2024

Shoot, I should have run two more checks before I landed this. @SamB, can you please send another PR that includes:

  • Ensure you are in the AUTHORS file
  • Add a CHANGELOG entry

@hildjj
Copy link
Contributor

hildjj commented Jun 19, 2024

@SamB I added you to the AUHTORS file in preparation for 4.0.3. Feel free to send me another pull request with any preferred naming or contact info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants